KAFKA-9610: Do not throw illegal state when remaining partitions are not empty#8169
Merged
guozhangwang merged 5 commits intoapache:trunkfrom Feb 26, 2020
Merged
KAFKA-9610: Do not throw illegal state when remaining partitions are not empty#8169guozhangwang merged 5 commits intoapache:trunkfrom
guozhangwang merged 5 commits intoapache:trunkfrom
Conversation
Member
There was a problem hiding this comment.
This doesn't really make sense, onPartitionsRevoked is always called before onAssignment
Member
There was a problem hiding this comment.
Not sure if we want to log as warn or debug though -- hitting this indicates we hit the (likely not that common) race condition, or a bug.
6919d9e to
1aae7fc
Compare
Contributor
Author
|
@guozhangwang could you also take a look and see if you could trigger a test? |
Contributor
|
test this please |
Contributor
Author
|
The failure was really weird as it is not related to the change: Will rebase trunk and see if this fixes |
1aae7fc to
2f716ca
Compare
Contributor
Author
Contributor
Fixed in #8170 |
added 5 commits
February 25, 2020 21:23
This reverts commit db81ce6.
This reverts commit b87d35f7eeec2a70a10a86ced9e300bccefc8c13.
2f716ca to
4f85b12
Compare
Contributor
|
test this please |
1 similar comment
Contributor
|
test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
handleRevocation, it is possible that previous onAssignment callback has cleaned up the stream tasks, which means no corresponding task could be found for given partitions. We should not throw here as this is expected behavior.Committer Checklist (excluded from commit message)