MINOR: valueFactory's key is consumerId#817
Closed
zqhxuyuan wants to merge 1 commit into
Closed
Conversation
the key of partitionAssignment's valueFactory is consumerId, not topic. partitionAssignment.getAndMaybePut(threadId.consumer)
zqhxuyuan
changed the title
Author
|
I just change parameter name, should pass jenkins... what's wrong? |
Contributor
|
Closing this since the old consumer has been removed from the codebase. |
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
harveyyue
pushed a commit
to harveyyue/kafka
that referenced
this pull request
Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the key of partitionAssignment's valueFactory is consumerId, not topic.
partitionAssignment.getAndMaybePut(threadId.consumer)