KAFKA-9793: Expand the try-catch for task commit in HandleAssignment#8402
Merged
guozhangwang merged 2 commits intoapache:trunkfrom Apr 6, 2020
Merged
KAFKA-9793: Expand the try-catch for task commit in HandleAssignment#8402guozhangwang merged 2 commits intoapache:trunkfrom
guozhangwang merged 2 commits intoapache:trunkfrom
Conversation
bbe55d8 to
76be91c
Compare
Contributor
|
test this please |
Member
|
Java 11 passed, but Java 8 failed with Could this be related? |
Contributor
Author
|
Let me check @mjsax |
Contributor
Author
|
Fixed by relaxing the ordering check @mjsax |
Member
|
Retest this please. |
Contributor
Author
|
Retest this please |
Contributor
|
test this please |
Contributor
Author
|
Only one test failure on jdk 8: |
Member
|
Retest this please. |
Contributor
|
Contributor
Author
|
@guozhangwang I think we need to merge #8424 first |
guozhangwang
approved these changes
Apr 4, 2020
Contributor
guozhangwang
left a comment
There was a problem hiding this comment.
LGTM, after fixing jenkins this should be good to go.
Contributor
|
test this please |
2 similar comments
Contributor
|
test this please |
Contributor
|
test this please |
Contributor
|
test this |
Contributor
|
test this please |
Contributor
|
Okay I'm done with jenkins bot and manually build two: https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1622 and https://builds.apache.org/job/kafka-pr-jdk11-scala2.13/5641 |
Contributor
|
Both jenkins succeed, merging to trunk now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title suggests, we would like to broaden this check so that we don't fail to close a doom-to-cleanup task.
Committer Checklist (excluded from commit message)