MINOR: Annotate KafkaAdminClientTest.testAlterClientQuotas() with @Test#8456
Closed
tombentley wants to merge 1 commit into
Closed
MINOR: Annotate KafkaAdminClientTest.testAlterClientQuotas() with @Test#8456tombentley wants to merge 1 commit into
tombentley wants to merge 1 commit into
Conversation
This public method is uncalled, but is clearly intended to be a test.
Member
Author
Contributor
|
@bdbyrne Can you take a look and review? This was a KIP-546 change. |
Contributor
|
LGTM - thank you! |
chia7712
approved these changes
Apr 10, 2020
Member
|
ok to test |
Contributor
|
The results of the failed test are long gone, but this is literally just a test annotation, and 2/3 test runs passed. I'll just go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KafkaAdminClientTest.testAlterClientQuotas() is uncalled. It is clearly intended to be a test method, but lacks
@Test.