MINOR: Reduce size of the ProducerStateEntry batchMetadata queue. #9980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satishd
reviewed
Jan 28, 2021
Member
satishd
left a comment
satishd
left a comment
There was a problem hiding this comment.
thanks @gardnervickers for the PR, left a minor comment.
Member
There was a problem hiding this comment.
minor: you may want to have it as new mutable.Queue[BatchMetadata](NumBatchesToRetain) instead of harcoding directly.
Contributor
Author
There was a problem hiding this comment.
Yes, good suggestion :)
satishd
approved these changes
Jan 29, 2021
Member
satishd
left a comment
satishd
left a comment
There was a problem hiding this comment.
thanks @gardnervickers for addressing the review comments. LGTM.
This reduces the size at construction of the batchMetadata queue from 16 entries to 5. The backing array will resize to 8 elements, cutting the queue size in half. We know that we will only allow a max of 5 entries in this queue, so this change will not change the alloc/copy behavior.
gardnervickers
force-pushed
the
size-batch-metadata-queue
branch
from
17898ea to
ba6958a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size at construction of the batchMetadata queue from 16
entries to 5. The backing array will be sized to 8 elements, cutting the array size
in half.
We know that we will only allow a max of 5 entries in this queue, so this change will not
change the alloc/copy behavior.