Skip to content

KARAF-6925 - Initial attempt at supporting spring-security-crypto#1259

Merged
jbonofre merged 1 commit into
apache:masterfrom
coheigea:KARAF-6925
Mar 6, 2021
Merged

KARAF-6925 - Initial attempt at supporting spring-security-crypto#1259
jbonofre merged 1 commit into
apache:masterfrom
coheigea:KARAF-6925

Conversation

@coheigea

@coheigea coheigea commented Nov 27, 2020

Copy link
Copy Markdown
Contributor

Some points to note:

  • In jaas/spring-security-crypto/pom.xml it just depends on a servicemix bundle, I wasn't sure whether to just depend on the normal spring jar here.
  • The feature I added could be reworked to remove dependency on a set version of Spring.
  • scrypt, bcrypt, pbkdf2, argon2 work well.
  • Remaining work: Update the default jaas file comments to show how to use it, and update the documentation.

@jbonofre
jbonofre self-requested a review November 27, 2020 13:00
@jbonofre

Copy link
Copy Markdown
Member

I would use a different approach embedding spring-security as private to avoid feature dependency. Let me rework this PR.

@jbonofre

Copy link
Copy Markdown
Member

As said, I will rework this one to avoid Spring bundles dependency and prefer spring-security embedded. I will do that tomorrow. Thanks !

@coheigea

Copy link
Copy Markdown
Contributor Author

Thanks @jbonofre, I was just making a trivial change to the logic.

@jbonofre

jbonofre commented Mar 6, 2021

Copy link
Copy Markdown
Member

As it's an optional JAAS bundle, it makes sense to keep it as a feature (no need to use private package as it's not part of "core" JAAS). LGTM.

@jbonofre
jbonofre merged commit 0485f44 into apache:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants