KARAF-6925 - Initial attempt at supporting spring-security-crypto#1259
Merged
Conversation
jbonofre
self-requested a review
November 27, 2020 13:00
Member
|
I would use a different approach embedding spring-security as private to avoid feature dependency. Let me rework this PR. |
Member
|
As said, I will rework this one to avoid Spring bundles dependency and prefer spring-security embedded. I will do that tomorrow. Thanks ! |
Contributor
Author
|
Thanks @jbonofre, I was just making a trivial change to the logic. |
Member
|
As it's an optional JAAS bundle, it makes sense to keep it as a feature (no need to use private package as it's not part of "core" JAAS). LGTM. |
jbonofre
approved these changes
Mar 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some points to note: