KARAF-7099 Provide util for Configuration PIDs#1346
Closed
oliverlietz wants to merge 1 commit intoapache:mainfrom
Closed
KARAF-7099 Provide util for Configuration PIDs#1346oliverlietz wants to merge 1 commit intoapache:mainfrom
oliverlietz wants to merge 1 commit intoapache:mainfrom
Conversation
Member
|
It would be great to have a quick abstract / description of the PR. Thanks. |
jbonofre
requested changes
May 6, 2021
| <!-- nullability --> | ||
| <dependency> | ||
| <groupId>org.jetbrains</groupId> | ||
| <artifactId>annotations</artifactId> |
Member
There was a problem hiding this comment.
Do we really need this dependency in util for null check ?
Member
Author
There was a problem hiding this comment.
In general I prefer to annotate parameters and return values but the dependency is of course not strictly required. The annotations (https://github.com/JetBrains/java-annotations) are used during analysis and compile time only and should have no negative impact.
Should I remove the annotations from ConfigurationPID?
Member
There was a problem hiding this comment.
Don't worry, I'm reworking your two PRs. Thanks !
Member
|
Superseeded by #1368 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.