KARAF-7098 JsonConfigInstaller ignores R7 factory configurations#1347
Closed
oliverlietz wants to merge 2 commits intoapache:mainfrom
Closed
KARAF-7098 JsonConfigInstaller ignores R7 factory configurations#1347oliverlietz wants to merge 2 commits intoapache:mainfrom
oliverlietz wants to merge 2 commits intoapache:mainfrom
Conversation
* Use util ConfigurationPID for parsing and representing PIDs * Do not create new configuration when calling deleteConfig(File) * Simplify logging * Rename parameter fileName to configKey where appropriate
Member
|
It seems that this PR includes #1346. It would be great to gather both in the same PR (unique PR), or link both together. Anyway two not related commits are not easy to review. |
jbonofre
requested changes
May 6, 2021
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
The PR and config bundle is not good. It should use org.apache.karaf.util.config as private package, else we have the following issue:
Message: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=minimal; type=karaf.feature; version=4.3.2.SNAPSHOT; filter:="(&(osgi.identity=minimal)(type=karaf.feature)(version>=4.3.2.SNAPSHOT))" [caused by: Unable to resolve minimal/4.3.2.SNAPSHOT: missing requirement [minimal/4.3.2.SNAPSHOT] osgi.identity; osgi.identity=config; type=karaf.feature [caused by: Unable to resolve config/4.3.2.SNAPSHOT: missing requirement [config/4.3.2.SNAPSHOT] osgi.identity; osgi.identity=org.apache.karaf.config.core; type=osgi.bundle; version="[4.3.2.SNAPSHOT,4.3.2.SNAPSHOT]"; resolution:=mandatory [caused by: Unable to resolve org.apache.karaf.config.core/4.3.2.SNAPSHOT: missing requirement [org.apache.karaf.config.core/4.3.2.SNAPSHOT] osgi.wiring.package; filter:="(osgi.wiring.package=org.apache.karaf.util.config)"]]]
Member
Author
|
I see, so embedding via e.g. |
Member
|
Yes, like the other util packages. But don't worry, I'm fixing that. Thanks ! |
Member
|
Superseeded by PR #1369 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.