Primitives should not be boxed just for Strign conversion#345
Closed
apupier wants to merge 1 commit intoapache:masterfrom
Closed
Primitives should not be boxed just for Strign conversion#345apupier wants to merge 1 commit intoapache:masterfrom
apupier wants to merge 1 commit intoapache:masterfrom
Conversation
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Member
|
R: @jbonofre |
jbonofre
reviewed
Sep 6, 2017
| } else if (c == 127) { | ||
| if (vt100_mode_backspace) { | ||
| o += (char) 8; | ||
| o += Integer.toString(8); |
Member
There was a problem hiding this comment.
It's a String whereas we cast to char.
Contributor
Author
There was a problem hiding this comment.
yes but the char is then autocasted to String. I think that we can get rid of this step, isn't it?
Member
There was a problem hiding this comment.
Agree, it's just a personal note for the merge ;)
ffang
added a commit
to ffang/karaf-1
that referenced
this pull request
Sep 10, 2019
[KARAF-6362][karaf-maven-plugin] client goal:only one command in scri…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aurélien Pupier apupier@redhat.com