Skip to content

Primitives should not be boxed just for Strign conversion #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apupier wants to merge 1 commit into from
Closed

Primitives should not be boxed just for Strign conversion #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion instance/src/main/java/org/apache/karaf/instance/main/Execute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ private static void exit(int rc) {
if (exitAllowed) {
System.exit(rc);
} else {
throw new RuntimeException("" + rc);
throw new RuntimeException(Integer.toString(rc));
}
}

Expand Down
2 changes: 1 addition & 1 deletion shell/ssh/src/main/java/org/apache/karaf/shell/ssh/SshServerAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public Object execute() throws Exception {
server.getProperties().put(SshServer.IDLE_TIMEOUT, Long.toString(idleTimeout));

// nio-workes
server.getProperties().put(SshServer.NIO_WORKERS, new Integer(nioWorkers).toString());
server.getProperties().put(SshServer.NIO_WORKERS, Integer.toString(nioWorkers));

// welcome banner
if (welcomeBanner != null) {
Expand Down
10 changes: 5 additions & 5 deletions webconsole/gogo/src/main/java/org/apache/karaf/webconsole/gogo/Terminal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,7 +1025,7 @@ private String[] vt100_parse_params(String p, String[] defaults) {
String prefix = "";
if (p.length() > 0) {
if (p.charAt(0) >= '<' && p.charAt(0) <= '?') {
prefix = "" + p.charAt(0);
prefix = Character.toString(p.charAt(0));
p = p.substring(1);
}
}
Expand Down Expand Up @@ -1710,14 +1710,14 @@ public synchronized String pipe(String d) {
vt100_keyfilter_escape = true;
} else if (c == 127) {
if (vt100_mode_backspace) {
o += (char) 8;
o += Integer.toString(8);
Copy link
Copy Markdown
Member

@jbonofre jbonofre Sep 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a String whereas we cast to char.

Copy link
Copy Markdown
Contributor Author

@apupier apupier Sep 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but the char is then autocasted to String. I think that we can get rid of this step, isn't it?

Copy link
Copy Markdown
Member

@jbonofre jbonofre Sep 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, it's just a personal note for the merge ;)

} else {
o += (char) 127;
o += Integer.toString(127);
}
} else {
o += c;
o += Integer.toString(c);
if (vt100_mode_lfnewline && c == 13) {
o += (char) 10;
o += Integer.toString(10);
}
}
}
Expand Down