KYLIN-3847 Flink cubing step : fact distinct#1154
Merged
shaofengshi merged 1 commit intoapache:masterfrom Apr 28, 2020
Merged
Conversation
|
This pull request introduces 1 alert when merging bc5a7b8 into ebc4c26 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #1154 +/- ##
============================================
- Coverage 25.05% 24.91% -0.15%
+ Complexity 6248 6245 -3
============================================
Files 1446 1449 +3
Lines 88305 88803 +498
Branches 12357 12413 +56
============================================
- Hits 22128 22124 -4
- Misses 64007 64506 +499
- Partials 2170 2173 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer jira: https://issues.apache.org/jira/browse/KYLIN-3847
Add flink fact distinct columns step, to avoid a mass of duplicated code with Spark and Flink implement self fact distinct step, add base class FactDistinctColumnsBase, extract core methods and variables from mapper/reducer class.
About different engine will implement the abstract method FactDistinctColumnsBase.Visitor.collect(...) to output the result from Spark/Flink engine framework.
Please help to review this code changes