Skip to content

Comments

KYLIN-4897 Add table snapshot and global dictionary cleaning in Stora…#1571

Merged
hit-lacus merged 1 commit intoapache:kylin-on-parquet-v2from
zhangayqian:KYLIN-4897
Feb 7, 2021
Merged

KYLIN-4897 Add table snapshot and global dictionary cleaning in Stora…#1571
hit-lacus merged 1 commit intoapache:kylin-on-parquet-v2from
zhangayqian:KYLIN-4897

Conversation

@zhangayqian
Copy link
Contributor

…geCleanupJob

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@zhangayqian
Copy link
Contributor Author

zhangayqian commented Feb 5, 2021

Test Evidence

bin/kylin.sh org.apache.kylin.tool.StorageCleanupJob

  • cleanup has not been modified for more than 12 hours and unused global dictionary
    image
    image

  • cleanup has not been modified for more than 12 hours and unused table snapshot
    image

  • cleanup has not been modified for more than 12 hours and unused segment parquet file
    image

bin/kylin.sh org.apache.kylin.tool.StorageCleanupJob --cleanupTableSnapshot false -cleanupThreshold 48

  • Just cleanup has not been modified for more than 48 hours and unused segment parquet file and global dictionary, table snapshot would not be cleanup
    image

@lgtm-com
Copy link

lgtm-com bot commented Feb 5, 2021

This pull request introduces 1 alert and fixes 1 when merging 3447859 into 2bcdb62 - view on LGTM.com

new alerts:

  • 1 for Result of multiplication cast to wider type

fixed alerts:

  • 1 for Dereferenced variable may be null

@hit-lacus hit-lacus merged commit 23d9082 into apache:kylin-on-parquet-v2 Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants