Skip to content

KYLIN-5027 Fix query for the cube dose not build basecuboid#1731

Merged
hit-lacus merged 1 commit intoapache:mainfrom
zhangayqian:KYLIN-canary
Aug 17, 2021
Merged

KYLIN-5027 Fix query for the cube dose not build basecuboid#1731
hit-lacus merged 1 commit intoapache:mainfrom
zhangayqian:KYLIN-canary

Conversation

@zhangayqian
Copy link
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Github Branch

As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 :

  1. The original branch kylin-on-parquet-v2 for Kylin 4.X (Parquet Storage) has been renamed to branch main, and configured as the default branch;
  2. The original branch master for Kylin 3.X (HBase Storage) has been renamed to branch kylin3 ;

Please check Intro to Kylin 4 architecture and INFRA-22166 if you are interested.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@9797e4c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2244e8b differs from pull request most recent head ab0a99d. Consider uploading reports for the commit ab0a99d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1731   +/-   ##
=======================================
  Coverage        ?   24.62%           
  Complexity      ?     4449           
=======================================
  Files           ?     1092           
  Lines           ?    61899           
  Branches        ?     8894           
=======================================
  Hits            ?    15242           
  Misses          ?    45049           
  Partials        ?     1608           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9797e4c...ab0a99d. Read the comment docs.

@zhangayqian zhangayqian force-pushed the KYLIN-canary branch 3 times, most recently from 2244e8b to ab0a99d Compare August 16, 2021 09:32
@zhangayqian zhangayqian changed the title Add switch config for sparder canary tool KYLIN-5027 Fix query for the cube dose not build basecuboid Aug 16, 2021
@lgtm-com
Copy link

lgtm-com bot commented Aug 16, 2021

This pull request introduces 1 alert and fixes 1 when merging ab0a99d into 9797e4c - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

fixed alerts:

  • 1 for Cast from abstract to concrete collection

@zhangayqian zhangayqian force-pushed the KYLIN-canary branch 4 times, most recently from 114c6d5 to 35179a4 Compare August 17, 2021 02:50
@lgtm-com
Copy link

lgtm-com bot commented Aug 17, 2021

This pull request introduces 1 alert and fixes 1 when merging 35179a4 into 9797e4c - view on LGTM.com

new alerts:

  • 1 for Type mismatch on container modification

fixed alerts:

  • 1 for Cast from abstract to concrete collection

@lgtm-com
Copy link

lgtm-com bot commented Aug 17, 2021

This pull request fixes 1 alert when merging 3c06333 into 9797e4c - view on LGTM.com

fixed alerts:

  • 1 for Cast from abstract to concrete collection

@lgtm-com
Copy link

lgtm-com bot commented Aug 17, 2021

This pull request fixes 1 alert when merging 55a436a into 9797e4c - view on LGTM.com

fixed alerts:

  • 1 for Cast from abstract to concrete collection

@hit-lacus hit-lacus merged commit 94b109f into apache:main Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants