KYLIN-3913: Remove getAllOutputs api in ExecutableManager to avoid OOM for large metadata#557
KYLIN-3913: Remove getAllOutputs api in ExecutableManager to avoid OOM for large metadata#557lshmouse wants to merge 1 commit intoapache:masterfrom
Conversation
…M for large metadata
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
=========================================
Coverage ? 25.37%
Complexity ? 5794
=========================================
Files ? 1371
Lines ? 81062
Branches ? 11365
=========================================
Hits ? 20572
Misses ? 58480
Partials ? 2010
Continue to review full report at Codecov.
|
|
Hi @lshmouse , have you tested your pr on a kylin instance with huge number of jobs. In your PR, org.apache.kylin.engine.mr.common.JobInfoConverter#parseToJobSearchResult will visit metastore to get the execute output data. I doubt this will decrease the performance, and make job listing slower. |
|
@nichunen Thanks for your reviews. I will update performance data later. |
|
It will be done in #630, the commit in this pr will be kept there, close this pr |
See: https://issues.apache.org/jira/browse/KYLIN-3913