Skip to content

KYLIN-3913: Remove getAllOutputs api in ExecutableManager to avoid OOM for large metadata#557

Closed
lshmouse wants to merge 1 commit intoapache:masterfrom
lshmouse:KYLIN-3913
Closed

KYLIN-3913: Remove getAllOutputs api in ExecutableManager to avoid OOM for large metadata#557
lshmouse wants to merge 1 commit intoapache:masterfrom
lshmouse:KYLIN-3913

Conversation

@lshmouse
Copy link
Copy Markdown

@asfgit
Copy link
Copy Markdown

asfgit commented Mar 27, 2019

Can one of the admins verify this patch?

1 similar comment
@asfgit
Copy link
Copy Markdown

asfgit commented Mar 27, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@0b7bda8). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #557   +/-   ##
=========================================
  Coverage          ?   25.37%           
  Complexity        ?     5794           
=========================================
  Files             ?     1371           
  Lines             ?    81062           
  Branches          ?    11365           
=========================================
  Hits              ?    20572           
  Misses            ?    58480           
  Partials          ?     2010
Impacted Files Coverage Δ Complexity Δ
.../apache/kylin/job/execution/ExecutableManager.java 36.19% <0%> (ø) 35 <0> (?)
...pache/kylin/engine/mr/common/JobInfoConverter.java 14.84% <0%> (ø) 6 <1> (?)
...va/org/apache/kylin/tool/JobInstanceExtractor.java 0% <0%> (ø) 0 <0> (?)
...java/org/apache/kylin/rest/service/JobService.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7bda8...e563d4f. Read the comment docs.

@shaofengshi shaofengshi requested a review from nichunen March 27, 2019 07:53
@nichunen
Copy link
Copy Markdown

nichunen commented Apr 1, 2019

Hi @lshmouse , have you tested your pr on a kylin instance with huge number of jobs.

In your PR, org.apache.kylin.engine.mr.common.JobInfoConverter#parseToJobSearchResult will visit metastore to get the execute output data. I doubt this will decrease the performance, and make job listing slower.

@lshmouse
Copy link
Copy Markdown
Author

lshmouse commented Apr 8, 2019

@nichunen Thanks for your reviews. I will update performance data later.

@nichunen
Copy link
Copy Markdown

nichunen commented May 6, 2019

It will be done in #630, the commit in this pr will be kept there, close this pr

@nichunen nichunen closed this May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants