Skip to content

#KYLIN-3913 Remove getAllOutputs api in ExecutableManager to avoid OOM for large metadata#630

Closed
ZhengshuaiPENG wants to merge 3 commits intoapache:masterfrom
ZhengshuaiPENG:KYLIN-3913
Closed

#KYLIN-3913 Remove getAllOutputs api in ExecutableManager to avoid OOM for large metadata#630
ZhengshuaiPENG wants to merge 3 commits intoapache:masterfrom
ZhengshuaiPENG:KYLIN-3913

Conversation

@ZhengshuaiPENG
Copy link
Copy Markdown

@asfgit
Copy link
Copy Markdown

asfgit commented May 6, 2019

Can one of the admins verify this patch?

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 4458

  • 6 of 194 (3.09%) changed or added relevant lines in 5 files are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 27.882%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java 3 6 50.0%
core-job/src/main/java/org/apache/kylin/job/execution/ExecutableManager.java 3 11 27.27%
engine-mr/src/main/java/org/apache/kylin/engine/mr/common/JobInfoConverter.java 0 13 0.0%
tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java 0 18 0.0%
server-base/src/main/java/org/apache/kylin/rest/service/JobService.java 0 146 0.0%
Files with Coverage Reduction New Missed Lines %
tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java 1 0.0%
engine-mr/src/main/java/org/apache/kylin/engine/mr/common/JobInfoConverter.java 4 19.08%
server-base/src/main/java/org/apache/kylin/rest/service/JobService.java 8 0.0%
Totals Coverage Status
Change from base Build 4453: 0.01%
Covered Lines: 22794
Relevant Lines: 81751

💛 - Coveralls

@ZhengshuaiPENG
Copy link
Copy Markdown
Author

Not a good design, close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants