[KYUUBI #3456] Ldap uses unboundid-ldapsdk to replace the original java implementation#3457
Closed
jiaoqingbo wants to merge 5 commits intoapache:masterfrom
Closed
[KYUUBI #3456] Ldap uses unboundid-ldapsdk to replace the original java implementation#3457jiaoqingbo wants to merge 5 commits intoapache:masterfrom
jiaoqingbo wants to merge 5 commits intoapache:masterfrom
Conversation
3 tasks
809b217 to
0cd594e
Compare
Contributor
Author
|
The failed test seems not related to this pr |
pan3793
reviewed
Sep 15, 2022
Codecov Report
@@ Coverage Diff @@
## master #3457 +/- ##
============================================
+ Coverage 51.35% 51.72% +0.37%
Complexity 13 13
============================================
Files 481 482 +1
Lines 26734 26977 +243
Branches 3750 3769 +19
============================================
+ Hits 13729 13955 +226
+ Misses 11662 11660 -2
- Partials 1343 1362 +19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag! Thank you for using Kyuubi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #3456
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request