Skip to content

[KYUUBI #3456] Ldap uses unboundid-ldapsdk to replace the original java implementation#3457

Closed
jiaoqingbo wants to merge 5 commits intoapache:masterfrom
jiaoqingbo:kyuubi3456
Closed

[KYUUBI #3456] Ldap uses unboundid-ldapsdk to replace the original java implementation#3457
jiaoqingbo wants to merge 5 commits intoapache:masterfrom
jiaoqingbo:kyuubi3456

Conversation

@jiaoqingbo
Copy link
Copy Markdown
Contributor

@jiaoqingbo jiaoqingbo commented Sep 8, 2022

Why are the changes needed?

fix #3456

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@jiaoqingbo
Copy link
Copy Markdown
Contributor Author

The failed test seems not related to this pr

Comment thread dev/dependencyList
Comment thread kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 16, 2022

Codecov Report

Merging #3457 (677eb97) into master (5dd245d) will increase coverage by 0.37%.
The diff coverage is 80.88%.

@@             Coverage Diff              @@
##             master    #3457      +/-   ##
============================================
+ Coverage     51.35%   51.72%   +0.37%     
  Complexity       13       13              
============================================
  Files           481      482       +1     
  Lines         26734    26977     +243     
  Branches       3750     3769      +19     
============================================
+ Hits          13729    13955     +226     
+ Misses        11662    11660       -2     
- Partials       1343     1362      +19     
Impacted Files Coverage Δ
...uthentication/LdapAuthenticationProviderImpl.scala 78.33% <77.96%> (-13.67%) ⬇️
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 97.33% <100.00%> (-0.19%) ⬇️
...apache/kyuubi/engine/JpsApplicationOperation.scala 77.41% <0.00%> (-3.23%) ⬇️
...ache/kyuubi/operation/KyuubiOperationManager.scala 79.45% <0.00%> (-2.74%) ⬇️
...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala 80.00% <0.00%> (-2.00%) ⬇️
...mon/src/main/scala/org/apache/kyuubi/Logging.scala 52.63% <0.00%> (-1.32%) ⬇️
...ain/scala/org/apache/kyuubi/engine/EngineRef.scala 72.26% <0.00%> (-0.85%) ⬇️
...a/org/apache/kyuubi/service/TFrontendService.scala 91.17% <0.00%> (-0.30%) ⬇️
...ache/kyuubi/jdbc/hive/KyuubiResultSetMetaData.java 0.00% <0.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiaoqingbo jiaoqingbo requested a review from pan3793 September 16, 2022 06:07
@github-actions
Copy link
Copy Markdown

Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!

Thank you for using Kyuubi!

@github-actions github-actions bot added the Stale label Dec 26, 2022
@github-actions github-actions bot closed this Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Ldap uses unboundid-ldapsdk to replace the original java implementation

3 participants