[KYUUBI #4388] Limit the max rows for get nextRowSet api#4395
Closed
lightning-L wants to merge 5 commits intoapache:masterfrom
Closed
[KYUUBI #4388] Limit the max rows for get nextRowSet api#4395lightning-L wants to merge 5 commits intoapache:masterfrom
lightning-L wants to merge 5 commits intoapache:masterfrom
Conversation
Contributor
Author
turboFei
reviewed
Feb 22, 2023
turboFei
reviewed
Feb 22, 2023
Codecov Report
@@ Coverage Diff @@
## master #4395 +/- ##
============================================
- Coverage 53.74% 53.74% -0.01%
Complexity 13 13
============================================
Files 564 564
Lines 30895 30907 +12
Branches 4164 4165 +1
============================================
+ Hits 16605 16610 +5
- Misses 12736 12742 +6
- Partials 1554 1555 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
87c7e26 to
7c2cd56
Compare
turboFei
reviewed
Feb 22, 2023
turboFei
reviewed
Feb 22, 2023
kyuubi-common/src/main/scala/org/apache/kyuubi/service/AbstractBackendService.scala
Outdated
Show resolved
Hide resolved
turboFei
approved these changes
Feb 22, 2023
4cd6eb7 to
6b85f6a
Compare
Member
|
After think twice, I think that we can set the default value to optional, to do not break the original behavior. |
turboFei
approved these changes
Feb 23, 2023
Member
|
thanks, merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request