Skip to content

Conversation

@juancarlosm
Copy link

Replace common/linode.py constant LINODE_PLAN_IDS by updated plan ids get function. Currently there are no plan 512 or 768, and plan id 3 is returns 1024 plan, but now is 2048

Juan Carlos Moreno added 3 commits April 12, 2013 17:01
Linode Driver: Not use plan ids constant, fetch updated plan ids
upps, foget to remove import
@Kami
Copy link
Member

Kami commented Apr 12, 2013

This patch seems reasonable to me. What do other people think - @jedsmith.

@juancarlosm Can you please open a ticket at https://issues.apache.org/jira/browse/LIBCLOUD and attach a final patch there?

Thanks

@juancarlosm
Copy link
Author

yes, of course. thanks

@jedsmith
Copy link
Contributor

I think it would be better if it remained static, as you're now incurring an (agreed, minimal) overhead for what ultimately is static data; for perspective, that data hasn't changed since I wrote it in 2010, and I doubt it will change again any time soon. If the overhead is genuinely minimal, I guess it's fine, but I think you're adding a bit of startup delay to the driver unnecessarily.

I had this on my list for this weekend, so thanks for getting to it, either way!

@Kami
Copy link
Member

Kami commented Apr 12, 2013

@jedsmith Thanks for looking into this.

@Kami
Copy link
Member

Kami commented Oct 26, 2013

(just doing some pull request cleanup)

@juancarlosm - Those changes are not relevant anymore, can you please close this pull request?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants