Skip to content

Add test for changed made in PR #1295#1299

Merged
Kami merged 1 commit intoapache:trunkfrom
micafer:ost_fix_float_ip
Jun 28, 2019
Merged

Add test for changed made in PR #1295#1299
Kami merged 1 commit intoapache:trunkfrom
micafer:ost_fix_float_ip

Conversation

@micafer
Copy link
Copy Markdown
Contributor

@micafer micafer commented Jun 28, 2019

Add test for changed made in PR #1295

Description

Add test to the fix proposed in PR #1295

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1299 into trunk will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1299      +/-   ##
==========================================
+ Coverage   85.95%   85.95%   +<.01%     
==========================================
  Files         359      359              
  Lines       73920    73924       +4     
  Branches     6708     6708              
==========================================
+ Hits        63535    63543       +8     
+ Misses       7701     7698       -3     
+ Partials     2684     2683       -1
Impacted Files Coverage Δ
libcloud/test/compute/test_openstack.py 94.9% <100%> (+0.01%) ⬆️
libcloud/test/compute/test_ec2.py 97.9% <0%> (+0.16%) ⬆️
libcloud/test/compute/test_upcloud.py 91.39% <0%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c0451...744b6eb. Read the comment docs.

@Kami Kami added the tests label Jun 28, 2019
@Kami Kami merged commit 6a34d68 into apache:trunk Jun 28, 2019
@Kami
Copy link
Copy Markdown
Member

Kami commented Jun 28, 2019

Merged, thanks.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.96%. Comparing base (f127e4e) to head (744b6eb).
⚠️ Report is 3972 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #1299      +/-   ##
==========================================
+ Coverage   85.95%   85.96%   +0.01%     
==========================================
  Files         359      359              
  Lines       73911    73924      +13     
  Branches     6705     6708       +3     
==========================================
+ Hits        63528    63543      +15     
+ Misses       7700     7698       -2     
  Partials     2683     2683              
Files with missing lines Coverage Δ
libcloud/test/compute/test_openstack.py 94.90% <100.00%> (+0.01%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants