Throw more user-friendly exception in EC2 driver on invalid request parameter type#1329
Merged
Kami merged 4 commits intoapache:trunkfrom Aug 1, 2019
Merged
Conversation
"params" argument. Parameters are sent via query parameters and not as part of a request body, as such, only strings / simple types are supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EC2 driver uses
GETand notPOSTmethod for all the outgoing HTTP requests. This means all the action parameters are sent via query parameters and not as a request body.This means all the parameter values needs to be of a simple type (string), otherwise it won't work as expected.
This pull request updates the code to fail loudly and throw a user-friendly exception in case invalid type is provided for
paramsdictionary item value. Previously a very cryptic error was throw so it was hard to figure out why it's failing.As a bonus, this change already uncovered a small bug in the Outscale driver - 3dadc47.
Resolves #1321.