Skip to content

openstack driver can create node from bootable vol #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kami merged 1 commit into from
Nov 1, 2019
Merged

openstack driver can create node from bootable vol #1362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libcloud/compute/drivers/openstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1515,7 +1515,9 @@ def _create_args_to_params(self, node, **kwargs):
if 'image' in kwargs:
server_params['imageRef'] = kwargs.get('image').id
else:
server_params['imageRef'] = node.extra.get('imageId')
server_params['imageRef'] = node.extra.get(
'imageId', ''
) if node else ''

if 'size' in kwargs:
server_params['flavorRef'] = kwargs.get('size').id
Expand Down
20 changes: 20 additions & 0 deletions libcloud/test/compute/test_openstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,6 +981,26 @@ def test_create_node_with_ex_config_drive(self):
self.assertEqual(node.name, 'racktest')
self.assertTrue(node.extra['config_drive'])

def test_create_node_from_bootable_volume(self):
size = NodeSize(
1, '256 slice', None, None, None, None, driver=self.driver)

node = self.driver.create_node(
name='racktest', size=size,
ex_blockdevicemappings=[
{
'boot_index': 0,
'uuid': 'ee7ee330-b454-4414-8e9f-c70c558dd3af',
'source_type': 'volume',
'destination_type': 'volume',
'delete_on_termination': False
}])

self.assertEqual(node.id, '26f7fbee-8ce1-4c28-887a-bfe8e4bb10fe')
self.assertEqual(node.name, 'racktest')
self.assertEqual(node.extra['password'], 'racktestvJq7d3')
self.assertEqual(node.extra['metadata']['My Server Name'], 'Apache1')

def test_destroy_node(self):
self.assertTrue(self.node.destroy())

Expand Down