Support aws eu-north-1 region (Stockholm) #1369#1370
Closed
michaelsembwever wants to merge 1 commit intoapache:trunkfrom
Closed
Support aws eu-north-1 region (Stockholm) #1369#1370michaelsembwever wants to merge 1 commit intoapache:trunkfrom
michaelsembwever wants to merge 1 commit intoapache:trunkfrom
Conversation
michaelsembwever
force-pushed
the
mck/trunk_1369-support-aws-eu_north_1
branch
from
ede37ae to
bf780f0
Compare
michaelsembwever
force-pushed
the
mck/trunk_1369-support-aws-eu_north_1
branch
from
bf780f0 to
e25cd66
Compare
Member
|
LGTM, thanks for the contribution. Just a heads up, in the future we plan to the move to the single driver class + "region" argument approach - #1366. |
Member
Author
Member
|
@michaelsembwever I will try to have a look at moving S3 driver to single region model soon. Sadly the code is a bit convoluted in regards to how class variables and class instance variables are used so there are some edge cases which need to be taken care correctly. |
2 tasks
Member
|
Merged in via #1371. Thanks again for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #1369
Support aws eu-north-1 region (Stockholm) #1369
Status
ready for testing and review.
Checklist (tick everything that applies)