Skip object checksum check on upload if server side AWS KMS encryption is used#1406
Merged
Kami merged 7 commits intoapache:trunkfrom Jan 14, 2020
Merged
Conversation
is encrypted using AWS KMS encryption. In such scenarios, ETag header doesn't contain object data MD5 digest. See https://docs.aws.amazon.com/AmazonS3/latest/API/RESTCommonResponseHeaders.html and apache#1401 for details.
It appears they become obsolete and unused during requests migration.
Codecov Report
@@ Coverage Diff @@
## trunk #1406 +/- ##
==========================================
+ Coverage 86.44% 86.46% +0.01%
==========================================
Files 366 366
Lines 76767 76773 +6
Branches 7529 7529
==========================================
+ Hits 66365 66378 +13
+ Misses 7534 7527 -7
Partials 2868 2868
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates S3 driver code to skip uploaded object checksum check at the end of the upload when server side AWS KMS encryption is used for that object.
In such scenario, ETag header value doesn't contain object data MD5 digest.
As part of that change I also noticed some of the tests were out of date and some of the mock http methods are not needed anymore so I did some cleanup. That likely happened during the requests migration.
Resolves #1401.