storage account default value in azure_arm#1448
Merged
asfgit merged 2 commits intoapache:trunkfrom Jun 6, 2020
Merged
Conversation
c-w
approved these changes
Apr 21, 2020
Member
|
@antoinebourayne Can you please add a corresponding test case so we can merge this? Besides that, LGTM 👍 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1068 Default Value of create_node in azure_arm
Description
The parameter "ex_storage_account" must be provided even if the "ex_use_managed_disks" is set as True. Therefore this will lead to an error even if no storage account is needed if "ex_use_managed_disks" is set as True.
Status
Replace this: describe the PR status. Examples: