digitalocean driver.list_nodes: size and image now is not null #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lovely, and people were complaining about JavaScript in the past... 😆 |
Contributor
Author
Support said that they don't care about this. We can make easy fix on Libcloud side special for gateway value: if gateway == "<nil>":
gateway = None |
Member
|
Change has been merged into trunk - thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
digitalocean driver.list_nodes: size and image now is not null
Fixes #1507
Status
Checklist (tick everything that applies)
P.S.
DO return
<nil>for some values instead ofnull, becauseGolang. I believe that it is a bug on their side. I'v created ticket in their support center.