Minor fix getting description of Ports#1543
Merged
micafer merged 4 commits intoapache:trunkfrom Feb 15, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #1543 +/- ##
==========================================
- Coverage 84.77% 83.07% -1.70%
==========================================
Files 388 394 +6
Lines 81521 84738 +3217
Branches 8243 9002 +759
==========================================
+ Hits 69111 70399 +1288
- Misses 9422 11274 +1852
- Partials 2988 3065 +77
Continue to review full report at Codecov.
|
Kami
approved these changes
Feb 12, 2021
Member
Kami
left a comment
Kami
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge such small fixes at your own convenience.
Kami
reviewed
Feb 12, 2021
| binding_vnic_type=element['binding:vnic_type'], | ||
| device_id=element['device_id'], | ||
| description=element['description'], | ||
| description=element.get('description', None), |
Member
There was a problem hiding this comment.
If you get a chance it would also be good to add a test case for it + changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fix getting description of Ports
Description
In some cases the port may not have the "description" field, and the "_to_port" function fails.
Status
Checklist (tick everything that applies)