Fix null value in DigitalOcean create a record#1570
Merged
Conversation
This fixes "field could not be unmarshalled" error when trying to send 'null' as a boolean value. It needs to be int or bool, not a string. Ref: https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record
Kami
approved these changes
May 2, 2021
Member
Kami
left a comment
There was a problem hiding this comment.
LGTM 👍
I wonder if null string is a left over from previous version of their API or similar.
Member
|
I see |
asfgit
pushed a commit
that referenced
this pull request
May 2, 2021
parameter in DigitalOcean DNS driver, add changelog entry for #1570.
d-mo
pushed a commit
to mistio/libcloud
that referenced
this pull request
Nov 15, 2021
parameter in DigitalOcean DNS driver, add changelog entry for apache#1570.
d-mo
pushed a commit
to mistio/libcloud
that referenced
this pull request
Nov 19, 2021
parameter in DigitalOcean DNS driver, add changelog entry for apache#1570.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #1570 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 394 394
Lines 84990 84990
Branches 9038 9038
=======================================
Hits 70550 70550
Misses 11373 11373
Partials 3067 3067
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix null value in DigitalOcean create a record
Description
This fixes "field could not be unmarshalled" error when trying to send
'null' as a boolean value. It needs to be int or bool, not a string.
Ref: https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record
Status
Replace this: describe the PR status. Examples:
Checklist (tick everything that applies)
[ ] ICLA (required for bigger changes)