Add disabled property to OpenStack images #1615
Merged
Kami merged 6 commits intoapache:trunkfrom Oct 22, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #1615 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 394 394
Lines 84999 85000 +1
Branches 9040 9040
=======================================
+ Hits 70558 70559 +1
Misses 11374 11374
Partials 3067 3067
Continue to review full report at Codecov.
|
Contributor
Author
|
Hi @vdloo, could you please review this small change? thanks! |
vdloo
approved these changes
Oct 18, 2021
Member
vdloo
left a comment
vdloo
left a comment
There was a problem hiding this comment.
lgtm 👍
looks like:
In [9]: mysize = conn.list_sizes()[10]
In [10]: mysize
Out[10]: <OpenStackNodeSize: id=673b9c55-8a76-41d1-9cb7-f6311143649e, name=m1.medium, ram=4096, disk=60, bandwidth=None, price=0.0, driver=Test OpenStack, vcpus=6, ...>
In [11]: mysize.extra
Out[11]: {'disabled': False}
Kami
approved these changes
Oct 22, 2021
Member
Kami
left a comment
Kami
left a comment
There was a problem hiding this comment.
LGTM.
Next time when a PR is approved, feel free to merge it yourself :)
This was referenced Oct 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add disabled property to OpenStack images
Description
Add disabled property to OpenStack images. See issue #1614.
Status
Checklist (tick everything that applies)