Fix is_valid_ip_address raising ValueError on embedded null byte

[Ashishjob]

Summary

libcloud.utils.networking.is_valid_ip_address is a predicate that should return True/False for whether a string is a valid IP address. It calls socket.inet_pton and catches OSError to return False for malformed input.

However, socket.inet_pton raises ValueError (not OSError) when the address string contains an embedded null byte, e.g. "1.2.3.4\x00". That ValueError was not caught, so instead of returning False the function propagated an exception to the caller:

>>> from libcloud.utils.networking import is_valid_ip_address
>>> is_valid_ip_address("1.2.3.4")
True
>>> is_valid_ip_address("1.2.3.4\x00")
ValueError: embedded null character   # expected: False

Fix

Catch ValueError as well and return False, since a string with an embedded null byte is not a valid address.

Tests

Added regression cases (IPv4 and IPv6 addresses containing embedded null bytes) to the existing test_is_valid_ip_address. Verified they fail before the change (uncaught ValueError) and pass after it. Full libcloud/test/test_utils.py passes (23 passed, 1 skipped).

Changelog

Changelog entry added under Common in a follow-up commit referencing this PR number.

[micafer]

LGTM

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.59%. Comparing base (8ffc0a3) to head (1e4c562).

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk    #2185   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files         352      352           
  Lines       81852    81854    +2     
  Branches     8771     8772    +1     
=======================================
+ Hits        68417    68421    +4     
+ Misses      10562    10561    -1     
+ Partials     2873     2872    -1     

Files with missing lines	Coverage Δ
libcloud/test/test_utils.py	98.30% <ø> (ø)
libcloud/utils/networking.py	97.06% <100.00%> (+0.18%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[micafer]

Tests are failing could you check it?