Skip to content

The hostname should be fullyQualifiedDomainName instead of hostname #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RoelVanNyen wants to merge 2 commits into from
Closed

The hostname should be fullyQualifiedDomainName instead of hostname #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a18eb67
the hostname should be fullyQualifiedDomainName instead of hostname, …
Apr 22, 2014
0eb87f8
Fix hostname tests for softlayer compute.
Apr 23, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcloud/compute/drivers/softlayer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def _to_node(self, host):

return Node(
id=host['id'],
name=host['hostname'],
name=host['fullyQualifiedDomainName'],
state=state,
public_ips=public_ips,
private_ips=private_ips,
Expand Down
4 changes: 2 additions & 2 deletions libcloud/test/compute/test_softlayer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def setUp(self):
def test_list_nodes(self):
nodes = self.driver.list_nodes()
node = nodes[0]
self.assertEqual(node.name, 'libcloud-testing1')
self.assertEqual(node.name, 'libcloud-testing1.example.com')
self.assertEqual(node.state, NodeState.RUNNING)
self.assertEqual(node.extra['password'], 'L3TJVubf')

Expand Down Expand Up @@ -73,7 +73,7 @@ def test_create_node(self):
location=self.driver.list_locations()[0],
size=self.driver.list_sizes()[0],
image=self.driver.list_images()[0])
self.assertEqual(node.name, 'libcloud-testing')
self.assertEqual(node.name, 'libcloud-testing.example.com')
self.assertEqual(node.state, NODE_STATE_MAP['RUNNING'])

def test_create_fail(self):
Expand Down