Skip to content

fixing missing parameter exception for ex_add_access_config function #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pmoosh wants to merge 1 commit into from
Closed

fixing missing parameter exception for ex_add_access_config function #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions libcloud/compute/drivers/gce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,7 +899,8 @@ def __init__(self, user_id, key=None, datacenter=None, project=None,
else:
self.region = None

def ex_add_access_config(self, node, name, nat_ip=None, config_type=None):
def ex_add_access_config(self, node, name, nic, nat_ip=None,
config_type=None):
"""
Add a network interface access configuration to a node.

Expand Down Expand Up @@ -934,10 +935,11 @@ def ex_add_access_config(self, node, name, nat_ip=None, config_type=None):

if nat_ip is not None:
config['natIP'] = nat_ip

params = {'networkInterface': nic}
request = '/zones/%s/instances/%s/addAccessConfig' % (zone_name,
node_name)
self.connection.async_request(request, method='POST', data=config)
self.connection.async_request(request, method='POST',
data=config, params=params)
return True

def ex_delete_access_config(self, node, name, nic):
Expand Down
4 changes: 2 additions & 2 deletions libcloud/test/compute/test_gce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,9 +1093,9 @@ def test_ex_get_project(self):

def test_ex_add_access_config(self):
self.assertRaises(ValueError, self.driver.ex_add_access_config,
'node', 'name')
'node', 'name', 'nic')
node = self.driver.ex_get_node('node-name', 'us-central1-a')
self.assertTrue(self.driver.ex_add_access_config(node, 'foo'))
self.assertTrue(self.driver.ex_add_access_config(node, 'foo', 'bar'))

def test_ex_delete_access_config(self):
self.assertRaises(ValueError, self.driver.ex_add_access_config,
Expand Down