Add Onapp IaaS platform support#487
Closed
MatthiasWiesnerCC wants to merge 1 commit intoapache:trunkfrom
Closed
Conversation
Member
|
Cool, thanks. Will have a look asap. |
prepare_tests.sh
Outdated
Member
There was a problem hiding this comment.
Can you please add Apache 2.0 license headers to those non-code related files and move them to contrib/?
Member
|
Can you please add some documentation? See |
libcloud/compute/drivers/onapp.py
Outdated
Member
There was a problem hiding this comment.
Instead of having those methods here, either add raise NotImplementedError or remove them - base NodeDriver class already throws this error by default if the method is not overridden in a sub class.
This way it's possible to programatically check and know that those methods are unimplemented. Python returns implicit None by default so doing that means it's hard / impossible to programatically check if those methods are implemented.
MatthiasWiesnerCC
force-pushed
the
onapp
branch
5 times, most recently
from
0bf2819 to
3860544
Compare
Author
|
Implement missing support for Virtual Server in OnApp node driver, as described in the OnApp API documentation: https://docs.onapp.com/display/34API/Virtual+Servers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.