Skip to content

DNSIMPLE: Priority typo fix #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phumpal wants to merge 1 commit into from
Closed

DNSIMPLE: Priority typo fix #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcloud/dns/drivers/dnsimple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,5 +289,5 @@ def _to_record(self, data, zone_id=None, zone=None):
'created_at': record.get('created_at'),
'updated_at': record.get('updated_at'),
'domain_id': record.get('domain_id'),
'prio': record.get('prio')}
'priority': record.get('prio')}
return Record(id, name, type, data, zone, self, extra=extra)
10 changes: 5 additions & 5 deletions libcloud/test/dns/test_dnsimple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,23 +94,23 @@ def test_list_records_success(self):
self.assertEqual(record1.type, RecordType.A)
self.assertEqual(record1.data, '1.2.3.4')
self.assertHasKeys(record1.extra, ['ttl', 'created_at', 'updated_at',
'domain_id', 'prio'])
'domain_id', 'priority'])

record2 = records[1]
self.assertEqual(record2.id, '2')
self.assertEqual(record2.name, 'www')
self.assertEqual(record2.type, RecordType.CNAME)
self.assertEqual(record2.data, 'example.com')
self.assertHasKeys(record2.extra, ['ttl', 'created_at', 'updated_at',
'domain_id', 'prio'])
'domain_id', 'priority'])

record3 = records[2]
self.assertEqual(record3.id, '32')
self.assertEqual(record3.name, '')
self.assertEqual(record3.type, RecordType.MX)
self.assertEqual(record3.data, 'mail.example.com')
self.assertHasKeys(record3.extra, ['ttl', 'created_at', 'updated_at',
'domain_id', 'prio'])
'domain_id', 'priority'])

def test_get_zone_success(self):
zone1 = self.driver.get_zone(zone_id='1')
Expand All @@ -133,7 +133,7 @@ def test_get_record_success(self):
self.assertEqual(record.type, RecordType.CNAME)
self.assertEqual(record.data, 'example.com')
self.assertHasKeys(record.extra, ['ttl', 'created_at', 'updated_at',
'domain_id', 'prio'])
'domain_id', 'priority'])

def test_create_zone_success(self):
DNSimpleDNSMockHttp.type = 'CREATE'
Expand All @@ -160,7 +160,7 @@ def test_create_record_success(self):
self.assertEqual(record.type, RecordType.MX)
self.assertEqual(record.data, 'mail.example.com')
self.assertHasKeys(record.extra, ['ttl', 'created_at', 'updated_at',
'domain_id', 'prio'])
'domain_id', 'priority'])

def test_update_record_success(self):
record = self.driver.get_record(zone_id='1',
Expand Down