Modified AtmosError so that the message argument is actually useful. #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the patch. I've modified it to follow Libcloud conventions and inherit from LibcloudError - http://svn.apache.org/viewvc/libcloud/trunk/libcloud/storage/drivers/atmos.py?view=diff&r1=1356063&r2=1356064&pathrev=1356064 |
Member
|
(just doing some pull request cleanup) @freakboy3742 - Those changes have been merged a long time ago, can you please close this pull request? Thanks! |
Author
|
Not sure why this wasn't automatically closed as a result of the commit, or why you can't close it yourself as a result of knowing that it's been committed... but sure - I can close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently implemented, AtmosError (in the Atmos storage backend) extends Exception, but then doesn't pass the message argument to the superclass. As a result, when an AtmosError is raised, the printed error message is useless.
Simply passing the message argument up to the superclass means that the message handling of the base Exception class is used, which means printed exceptions actually make sense.