S3 support for AWS Seoul region - #687
Closed
encyphered wants to merge 9 commits into
Closed
Conversation
Due to headers dictionary always have host / accept-encoding value, when perform 'raw' request, host / accept-encoding header would be duplicated. If you use AWSRequestSignerAlgorithmV4, this occurs invalid payload hash.
AWS S3 operations require HEAD / PUT / GET request
Type of header value may be other than a str, such as int. e.g. Value of content-lengh when POST/PUT
Missing X-AMZ-Content-SHA256 header can occur 400 bad request on several service such as S3
MockHttp.putrequest method signature is now same as httplib.HTTPConnection.putrequest
Contributor
There was a problem hiding this comment.
You need to shorten this line further.
Contributor
|
Hi @encyphered this PR is missing a small change before it can be merged. please see the build status light. |
Contributor
|
Thanks @encyphered LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support S3 Seoul region. In addition, this PR includes modification about Amazon signature V4 due to Seoul region does not support signature V2.
Modification that S3 requires: