Skip to content

LIBCLOUD-606 Can not connect to AWS with IAM role temporary credentials #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alejandrogr wants to merge 5 commits into from
Closed

LIBCLOUD-606 Can not connect to AWS with IAM role temporary credentials #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a82e675
LIBCLOUD-606 Can not connect to AWS with IAM role temporary credentials
alejandrogr Jun 21, 2016
20ae7d9
fix(): check attribute token exists in BaseEC2NodeDriver
alejandrogr Jun 30, 2016
fd3bf53
add tests for temporary token support on EC2NodeDriver
alejandrogr Jun 30, 2016
e44fbf0
fix(): miltiple spaces after keyword
alejandrogr Jun 30, 2016
8823f2a
remove unnecesary blank lines in test
alejandrogr Jun 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions libcloud/compute/drivers/ec2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5398,7 +5398,13 @@ def ex_replace_route(self, route_table, cidr,

def _ex_connection_class_kwargs(self):
kwargs = super(BaseEC2NodeDriver, self)._ex_connection_class_kwargs()
kwargs['signature_version'] = self.signature_version
if hasattr(self, 'token') and self.token is not None:
kwargs['token'] = self.token
# Force signature_version 4 for tokens or auth breaks
kwargs['signature_version'] = '4'
else:
kwargs['signature_version'] = self.signature_version

return kwargs

def _to_nodes(self, object, xpath):
Expand Down Expand Up @@ -6335,7 +6341,7 @@ class EC2NodeDriver(BaseEC2NodeDriver):
}

def __init__(self, key, secret=None, secure=True, host=None, port=None,
region='us-east-1', **kwargs):
region='us-east-1', token=None, **kwargs):
if hasattr(self, '_region'):
region = self._region

Expand All @@ -6345,6 +6351,7 @@ def __init__(self, key, secret=None, secure=True, host=None, port=None,

details = REGION_DETAILS[region]
self.region_name = region
self.token = token
self.api_name = details['api_name']
self.country = details['country']
self.signature_version = details.get('signature_version',
Expand Down
13 changes: 13 additions & 0 deletions libcloud/test/compute/test_ec2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,19 @@ def setUp(self):
self.driver = EC2NodeDriver(*EC2_PARAMS,
**{'region': self.region})

def test_instantiate_driver_with_token(self):
token = 'temporary_credentials_token'
driver = EC2NodeDriver(*EC2_PARAMS, **{'region': self.region, 'token': token})
self.assertTrue(hasattr(driver, 'token'), 'Driver has no attribute token')
self.assertEquals(token, driver.token, "Driver token does not match with provided token")

def test_driver_with_token_signature_version(self):
token = 'temporary_credentials_token'
driver = EC2NodeDriver(*EC2_PARAMS, **{'region': self.region, 'token': token})
kwargs = driver._ex_connection_class_kwargs()
self.assertIn('signature_version', kwargs)
self.assertEquals('4', kwargs['signature_version'], 'Signature version is not 4 with temporary credentials')

def test_create_node(self):
image = NodeImage(id='ami-be3adfd7',
name=self.image_name,
Expand Down