Revamp the Filters page
#2717
Merged
Revamp the Filters page
#2717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR we: - add a section about the filtering process, that explains in detail all the places, where a filter can be configured. - add the description of 3 filters, - improve the documentation of the remaining filters, by replacing the complete XML configuration examples with shorter examples in 4 formats that concentrate on the filter itself. Closes #2529, [LOG4J2-3485](https://issues.apache.org/jira/browse/LOG4J2-3485) and [LOG4J2-3682](https://issues.apache.org/jira/browse/LOG4J2-3682).
vy
approved these changes
Jul 7, 2024
Member
vy
left a comment
vy
left a comment
There was a problem hiding this comment.
Great job @ppkarwasz! 💯 Finally I understood how filters work! 🤯 Dropped some minor remarks.
src/site/antora/modules/ROOT/examples/manual/filters/ContextMapFilter.json
Show resolved
Hide resolved
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
vy
reviewed
Jul 8, 2024
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we:
Closes #2529,
LOG4J2-3485 and
LOG4J2-3682.