Skip to content

Extend plugin processor message filtering and add [Log4j] prefixes - #4228

Open
DragonFSKY wants to merge 1 commit into
apache:2.xfrom
DragonFSKY:fix-4225-plugin-processor-messages
Open

Extend plugin processor message filtering and add [Log4j] prefixes#4228
DragonFSKY wants to merge 1 commit into
apache:2.xfrom
DragonFSKY:fix-4225-plugin-processor-messages

Conversation

@DragonFSKY

Copy link
Copy Markdown

Fixes #4225.

This change:

  • makes GraalVmProcessor respect the existing log4j.plugin.processor.minAllowedMessageKind annotation processor option;
  • prefixes diagnostics emitted by PluginProcessor and GraalVmProcessor with [Log4j];
  • preserves the default NOTE threshold and the existing severity filtering semantics;
  • keeps plugin descriptor and GraalVM metadata generation independent from diagnostic filtering;
  • updates the processor tests, plugin manual, and changelog.

The diagnostic prefix is an intentional text change. No generated file format or public API is changed.

Verification

  • ./mvnw -pl log4j-core-test -am -Dtest=GraalVmProcessorTest,PluginProcessorPublicSetterTest -Dsurefire.failIfNoSpecifiedTests=false test (21 tests)
  • ./mvnw -pl log4j-core,log4j-core-test spotless:check
  • ./mvnw verify (41 reactor modules)
  • git diff --check

Checklist

  • Changes are based on the 2.x branch.
  • The Maven verification succeeds.
  • A changelog entry is included under src/changelog/.2.x.x.
  • Tests are provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Consider making plugin builds less chatty

1 participant