Don't get windows username in .NET Standard 2.0 #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the .NET Standard 2.0 version on Linux throws `PlatformNotSupportedException` See https://issues.apache.org/jira/browse/LOG4NET-652
fluffynuts
requested changes
Sep 29, 2020
Contributor
fluffynuts
left a comment
fluffynuts
left a comment
There was a problem hiding this comment.
NETSTANDARD is a valid choice for win32 targets too
| if (m_data.UserName == null && this.m_cacheUpdatable) | ||
| { | ||
| #if (NETCF || SSCLI || NETSTANDARD1_3) // NETSTANDARD1_3 TODO requires platform-specific code | ||
| #if (NETCF || SSCLI || NETSTANDARD) // NETSTANDARD TODO requires platform-specific code |
Contributor
There was a problem hiding this comment.
win32 is a valid target for netstandard too -- surely there's a better alternative?
Contributor
There was a problem hiding this comment.
(for example: if the platform is !win32, we could try to invoke whoami)
Contributor
|
Thanks for the contribution. This has been resolved in master and I have a release pending a vote on the dev lists for 2.0.12. I'm closing this out as people are looking for the fix. I would have preferred to have had your work & commit history so that the change would be attributed to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the .NET Standard 2.0 version on Linux throws
PlatformNotSupportedExceptionSee https://issues.apache.org/jira/browse/LOG4NET-652