Skip to content

SOLR-14238: Fix HdfsDirectory to no longer overwrite existing files.#1237

Merged
jpountz merged 1 commit intoapache:masterfrom
jpountz:hdfs_overwrite
Feb 4, 2020
Merged

SOLR-14238: Fix HdfsDirectory to no longer overwrite existing files.#1237
jpountz merged 1 commit intoapache:masterfrom
jpountz:hdfs_overwrite

Conversation

@jpountz
Copy link
Copy Markdown
Contributor

@jpountz jpountz commented Feb 4, 2020

No description provided.

Copy link
Copy Markdown
Contributor

@risdenk risdenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpountz thanks. Change looks reasonable. I'm assuming this is due to the contract for a directory? I can run through the hdfs tests in a few hours.

@jpountz
Copy link
Copy Markdown
Contributor Author

jpountz commented Feb 4, 2020

@risdenk Correct. I'd also like to add support for createTempOutput in a follow-up change. The lack of support for it in HdfsDirectory means Solr tests don't pass on my other pull request #1179, and one way to make it work would be to generate temporary file names until creating a file with this name doesn't throw a FileAlreadyExistsException, like we do in FSDirectory.

@jpountz jpountz merged commit 2d8428e into apache:master Feb 4, 2020
@jpountz
Copy link
Copy Markdown
Contributor Author

jpountz commented Feb 4, 2020

Thanks @risdenk !

@jpountz jpountz deleted the hdfs_overwrite branch February 4, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants