Fix disabling of bulk scoring in monitor#16350
Merged
Merged
Conversation
The monitor wraps all queries in a ForceNoBulkScoringQuery to ensure that it runs everything doc-at-a-time and doesn't allocate large bulk buffers for searches over a tiny number of documents. Changes to the bulk scoring API in Weight and ScorerSupplier meant that this optimization was silently disabled. Add a new test to ensure that bulk scoring is properly disabled, and re-work ForceNoBulkScoringQuery so that it behaves as expected.
romseygeek
added a commit
that referenced
this pull request
Jul 6, 2026
The monitor wraps all queries in a ForceNoBulkScoringQuery to ensure that it runs everything doc-at-a-time and doesn't allocate large bulk buffers for searches over a tiny number of documents. Changes to the bulk scoring API in Weight and ScorerSupplier meant that this optimization was silently disabled. Add a new test to ensure that bulk scoring is properly disabled, and re-work ForceNoBulkScoringQuery so that it behaves as expected.
dweiss
pushed a commit
that referenced
this pull request
Jul 7, 2026
The sanity check added in #16350 assumes that searching the un-wrapped ThrowsOnBulkScoreQuery always calls ScorerSupplier#bulkScorer. With newSearcher(reader) the searcher may be an AssertingIndexSearcher, whose ScorerSupplier sometimes builds the bulk scorer from scorer() instead of delegating, so the expected AssertionError is never thrown: gradlew -p lucene/monitor test --tests TestForceNoBulkScoringQuery \ -Dtests.seed=BDD18A3ADD885193 Use a plain IndexSearcher so the dispatch under test is deterministic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The monitor wraps all queries in a ForceNoBulkScoringQuery to ensure that it runs everything doc-at-a-time and doesn't allocate large bulk buffers for searches over a tiny number of documents. Changes to the bulk scoring API in Weight and ScorerSupplier meant that this optimization was silently disabled.
Add a new test to ensure that bulk scoring is properly disabled, and re-work ForceNoBulkScoringQuery so that it behaves as expected.