Order two-phase iterators in DenseConjunctionBulkScorer by matchCost#16370
Merged
Conversation
Currently two-phase iterators are ordered by their approximation cost. Many two-phase implementations use maxDoc as their approximation, however, meaning that we don't necessarily get a good ordering between them and more expensive matches can be called unnecessarily. This adds an additional comparison layer for two-phase iterators that orders by matchCost.
romseygeek
added a commit
that referenced
this pull request
Jul 7, 2026
…16370) Currently two-phase iterators are ordered by their approximation cost. Many two-phase implementations use maxDoc as their approximation, however, meaning that we don't necessarily get a good ordering between them and more expensive matches can be called unnecessarily. This adds an additional comparison layer for two-phase iterators that orders by matchCost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently two-phase iterators are ordered by their approximation cost. Many two-phase implementations use maxDoc as their approximation, however, meaning that we don't necessarily get a good ordering between them and more expensive matches can be called unnecessarily.
This adds an additional comparison layer for two-phase iterators that orders by matchCost.