Fix PointInSetQuery#ramBytesUsed to include retained bounds arrays#16406
Open
Sasilekha wants to merge 2 commits into
Open
Fix PointInSetQuery#ramBytesUsed to include retained bounds arrays#16406Sasilekha wants to merge 2 commits into
Sasilekha wants to merge 2 commits into
Conversation
Sasilekha
marked this pull request as ready for review
July 20, 2026 07:22
Contributor
Author
|
@mikemccand can you help review this pr please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #16405
PointInSetQuery retains two byte[] fields (lowerPoint, upperPoint) allocated in its constructor but its cached ramBytesUsed sums only field & sortedPackedPoints where both arrays are missing
ramBytesUsed = BASE_RAM_BYTES + RamUsageEstimator.sizeOfObject(field) + RamUsageEstimator.sizeOfObject(sortedPackedPoints)
Every non-empty query built via LongPoint.newSetQuery, IntPoint.newSetQuery, FloatPoint.newSetQuery etc therefore underreports its footprint to LRUQueryCache causing cached entries to stay resident longer than maxRamBytesUsed intends to