perf: optimize StateSet.equals to eliminate heap allocations during a…#16414
Open
rajat315315 wants to merge 2 commits into
Open
perf: optimize StateSet.equals to eliminate heap allocations during a…#16414rajat315315 wants to merge 2 commits into
rajat315315 wants to merge 2 commits into
Conversation
…utomaton determinization and add performance benchmarks.
Contributor
Author
|
Attaching the Benchmark file used to generate the results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #16413
📊 Benchmark & GC Allocation Metrics
Evaluated using
ThreadMXBean.getThreadAllocatedBytes()andGarbageCollectorMXBeanacross 30 determinization runs on complex NFA union automata (1,000 regex terms with overlapping state sets):determinize()