Backport changes to action revisions and some minor differences in wo… - #16641
Merged
Conversation
dweiss
commented
Sep 5, 2026
|
|
||
| - name: Run gradle tests | ||
| run: ./gradlew test "-Ptask.times=true" "-Pvalidation.errorprone=false" "-Ptests.workDir=/tmp/tmpfs/lucene" | ||
| run: ./gradlew displayGradleDiagnostics allOptions test "-Ptask.times=true" "-Pvalidation.errorprone=false" |
Contributor
Author
There was a problem hiding this comment.
Intentional. We do want those diagnostics.
dweiss
commented
Sep 5, 2026
Comment on lines
+14
to
+23
| groups: | ||
| # codeql init/analyze must match exactly: validate each others versions | ||
| codeql: | ||
| patterns: | ||
| - github/codeql-action/* | ||
| # group patch/minor updates, typically no breaking changes | ||
| actions: | ||
| update-types: | ||
| - patch | ||
| - minor |
Contributor
Author
There was a problem hiding this comment.
Applied just to shrink the diff surface since dependabot works on the main branch only, I think.
rmuir
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of github action hashes to 10x.
I also wanted to backport prek and linters but this would require us to apply a fairly extensive follow-up cleanups (like it was done on main - glob imports, typos, all sorts of other oddities). May be too much to digest.