Skip to content

Update stale skill-validator / skill-validate references to the renamed skill-and-tool-validator #351

Description

@justinmclean

What's broken

Summary

The validator tool was renamed from skill-validator (CLI skill-validate)
to skill-and-tool-validator (CLI skill-and-tool-validate), but several
docs and specs under tools/spec-loop/ still use the old name. The commands
they print no longer run. Update the stale references to the new name.

Background

tools/skill-validator/ no longer exists; the tool now lives at
tools/skill-and-tool-validator/ and its CLI is skill-and-tool-validate
(see tools/skill-and-tool-validator/README.md, and the already-correct
entries in docs/labels-and-capabilities.md). The spec-loop docs were not
updated in the rename, so anyone copy-pasting a uv run --project tools/skill-validator ... skill-validate command from a spec hits a
non-existent project.

Where to look

Let grep be the source of truth, since line numbers drift:

git grep -nE "skill-validator|skill-validate\b" -- ':!tools/skill-and-tool-validator' | grep -v skill-and-tool

As of now that surfaces references in tools/spec-loop/AGENTS.md,
tools/spec-loop/IMPLEMENTATION_PLAN.md, and the specs
adoption-and-setup.md, drafting-mode.md, meta-and-quality-tooling.md,
pairing-mode.md, security-issue-lifecycle.md, and triage-mode.md.
Replace:

  • tools/skill-validatortools/skill-and-tool-validator
  • the CLI skill-validateskill-and-tool-validate

Two spots need judgement, not blind replace:

  1. tools/spec-loop/specs/meta-and-quality-tooling.md describes the tool
    itself
    (its name and CLI in prose), so update the wording, not just the
    commands.
  2. tools/skill-evals/evals/setup-override-upstream/.../report.md contains
    skill-validate inside mock fixture data (a sample PR checklist). Updating
    fixture text can change what the eval asserts, so re-run that suite after
    editing and confirm expected.json still matches:
    uv run --project tools/skill-evals skill-eval tools/skill-evals/evals/setup-override-upstream/.

Acceptance criteria

  • The grep command above returns no hits (no skill-validator / skill-validate references remain outside the tool's own directory).
  • Every uv run command that referenced the validator now uses tools/skill-and-tool-validator and skill-and-tool-validate and runs successfully.
  • meta-and-quality-tooling.md prose names the tool correctly.
  • The setup-override-upstream eval suite still passes.

Estimated effort

~1 hour for someone new to the codebase.

Getting started


This issue was drafted with an AI-assisted tool and reviewed by a maintainer before posting.

Which layer

skill-and-tool-validator

How to reproduce

N/A

Expected vs actual

see acceptance criteria

Surface area (optional)

No response

Environment (optional)

No response

Metadata

Metadata

Labels

bugSomething isn't workinggood first issueGood for newcomers

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions