style(skills): apply ruff format and wire skills/ into workspace checks - #1077
Open
Arnxvvv wants to merge 1 commit into
Open
style(skills): apply ruff format and wire skills/ into workspace checks#1077Arnxvvv wants to merge 1 commit into
Arnxvvv wants to merge 1 commit into
Conversation
Applies the infrastructure from apache#1054 (create skills/pyproject.toml as a workspace member with ruff, mypy, and pytest config; fix type-checking issues in scan_ci_runners.py and collect_status.py) and then runs ruff format on all Python under skills/. The formatter reflowed 9 files — long set literals, regex constants, and argument lists wrapped to respect the 110-char line limit. No logic moves. The temporary [tool.magpie.checks] skip = [ruff-format] block is removed now that formatting has landed. Closes apache#1076.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/as a workspace member (skills/pyproject.tomladded and declared in root[tool.uv.workspace] members), bringing helper scripts and guards under standard CI linting, type-checking, and testing.ruff formatacross all Python code underskills/, reflowing long set literals, regex constants, and multiline argument lists to comply with the 110-character line-length standard without altering runtime logic.[tool.magpie.checks] skip = ["ruff-format"]block so thatrun-workspace-check.shand pre-commit hooks run the formatter check automatically acrossskills/.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
uv run pytest/ruff check/mypypasses:uv run --directory skills --project . ruff format --check .(9 files verified formatted)uv run --directory skills --project . ruff check .(all lint rules passed clean)uv run --directory skills --project . python -m mypy .(clean type-check across 9 source files)uv run --directory skills --project . python -m pytest(9 passed in 0.14s)uv lock --checkpasses withmagpie-skills v0.1.0member resolved.RFC-AI-0004 compliance
<PROJECT>,<tracker>,<upstream>,<security-list>) used in all skill / tool prose (thecheck-placeholdersprek hook is the mechanical gate)Linked issues
Notes for reviewers (optional)
skills/pyproject.toml, workspace member registration,uv.lockupdate, and type annotations inscan_ci_runners.py/collect_status.py) along with the mechanicalruff formatchanges so the branch is completely self-contained and ready for immediate CI testing.