chore(release): gitignore RC build artefacts so they can't be committed#789
Merged
Conversation
release-rc-cut builds the source zip + .asc + .sha512 in the repo root as untracked files, so a stray `git add .` could commit an RC artefact. Add ignore rules for them to the repo .gitignore, and add a gitignore-first note to the release-rc-cut build recipe (Section 2) so adopters do the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-rc-cutbuilds the source artefact (apache-magpie-<version>-source.zip), its detached signature (.asc), and its checksum (.sha512) in the repo root as untracked files. Those get staged todist/devviasvnand must never be committed to git — but a straygit add ./git commit -aat the wrong moment could pick them up.This ignores them and documents the guard in the skill.
Changes
.gitignore— ignore/apache-magpie-*-source.zip,.asc, and.sha512(mirrors the existing "Apache RAT working artefacts" pattern already in the file). Verified withgit check-ignorethat all three RC artefacts now match.skills/release-rc-cut/SKILL.md— Section 2 (Build) now tells the RM to gitignore the RC artefacts first (via a committed glob like*-source.zip*) so adopters get the same protection. Kept SKILL.md at 500 lines (trimmed a line from the tag-command note).Test plan
git check-ignore apache-magpie-0.1.0-source.zip{,.asc,.sha512}→ all three ignored.skill-and-tool-validatepasses, no new warnings (SKILL.md at 500 lines).🤖 Generated with Claude Code