build(license): exclude .gitignore from RAT instead of stamping a header#849
Merged
Merged
Conversation
…der (apache#846/apache#847 reversal) Reverse the approach from apache#846/apache#847. Rather than stamping the full ASF header into every tracked .gitignore and forcing RAT to scan them, treat .gitignore as hash-comment config with no downstream licensing significance and exclude it from the RAT check. - Strip the ASF header from all 9 tracked .gitignore files. - .rat-excludes: add an explicit **/.gitignore + .gitignore exclusion (parsed-scm GIT self-excludes them too; the entry makes it explicit). - .github/workflows/rat.yml: drop `--input-include '**/.gitignore'`; the ignore files are no longer force-included, so the default exclusion holds. - tools/dev/add-license-headers.py: revert to Markdown-only (drop ASF_HEADER_HASH, the .gitignore stamping branch, and .gitignore from --all's tracked targets). - .pre-commit-config.yaml: hook `files:` back to `\.md$`, name/comment back to Markdown-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverses #846 and #847. Instead of stamping the full ASF header into every tracked
.gitignoreand forcing RAT to scan them, this treats.gitignoreas hash-comment config with no downstream licensing significance and excludes it from the RAT check — per @justinmclean's point on #847 that a.gitignoreis just a list of files and needs no header..gitignorefiles..rat-excludes: add an explicit**/.gitignore+.gitignoreexclusion (parsed-scm GIT self-excludes them too; the entry makes it explicit)..github/workflows/rat.yml: drop--input-include '**/.gitignore', so the default exclusion holds again.tools/dev/add-license-headers.py: revert to Markdown-only..pre-commit-config.yaml: hookfiles:back to\.md$.