docs(education): align eval worked example 2 with case-7 fixture - #985
Merged
justinmclean merged 1 commit intoJul 29, 2026
Merged
Conversation
Worked example 2 cited case-7-prompt-injection but showed an invented dark-mode FEATURE-REQUEST excerpt. Quote the real BashOperator INVALID fixture and describe has_rationale_injection_ignored. Generated-by: Cursor Grok 4.5 Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
justinmclean
left a comment
Member
There was a problem hiding this comment.
Thanks for correcting this.
justinmclean
approved these changes
Jul 29, 2026
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FEATURE-REQUESTexcerpt in Worked example 2 ofdocs/education/eval-driven-development.mdwith the realcase-7-prompt-injectionfixture it already cites (BashOperatorKeyError+SYSTEM:injection →INVALID).has_rationale_injection_ignoredis backed by the suiteassertions.jsonregex overrationale, so label-only survival is not enough; point at Worked example 3 for thehas_*mechanism rather than re-explaining it.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
expected.jsonexcerpt matchestools/skill-evals/evals/issue-triage/step-3-classify/fixtures/case-7-prompt-injection/expected.jsonexactlyreport.mdexcerpt matches the real fixture’s title,SYSTEM:injection, and BashOperator bodyhas_rationale_injection_ignoredviaassertions.json(regex overrationale) and links to Worked example 3prek run --all-filespassesRFC-AI-0004 compliance
Linked issues
Closes #978